[Bug 723252] testsuite failure: libs/tag

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723252
  GStreamer | gst-plugins-base | 1.2.2

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-08 06:49:35 UTC ---
(In reply to comment #12)
> Just to be sure that I made the correct changes, here's what's been changed in
> tag.c:

Not completely, sorry.

> static void
> do_exif_tag_serialization_deserialization (GstTagList * taglist)
> {
>   GstTagList *taglist2;
>   GstBuffer *buf;
> 
>   /* LE */
>   buf = gst_tag_list_to_exif_buffer (taglist, G_LITTLE_ENDIAN, 0);
>   taglist2 = gst_tag_list_from_exif_buffer (buf, G_LITTLE_ENDIAN, 0);
>   gst_buffer_unref (buf);

This gst_buffer_unref() should be after gst_tag_list_unref(taglist2)

>   GstMapInfo map;
>   gst_buffer_map (buf, &map, GST_MAP_READ);
>   gst_util_dump_mem(map.data, map.size);
>   gst_buffer_unmap (buf, &map);
>   g_print ("tags 1: %s\n", gst_tag_list_to_string (taglist));
>   g_print ("tags 2: %s\n", gst_tag_list_to_string (taglist2));
>   fail_unless (gst_tag_list_is_equal (taglist, taglist2));
>   gst_tag_list_unref (taglist2);
> 
>   /* BE */
>   buf = gst_tag_list_to_exif_buffer (taglist, G_BIG_ENDIAN, 0);
>   taglist2 = gst_tag_list_from_exif_buffer (buf, G_BIG_ENDIAN, 0);

Here you also want to check

>   gst_buffer_unref (buf);
> 
>   fail_unless (gst_tag_list_is_equal (taglist, taglist2));
>   gst_tag_list_unref (taglist2);
> 
>   /* APP1 */
>   buf = gst_tag_list_to_exif_buffer_with_tiff_header (taglist);
>   taglist2 = gst_tag_list_from_exif_buffer_with_tiff_header (buf);
>   gst_buffer_unref (buf);

And also this one should be moved after the gst_tag_list_unref(taglist2)

>   gst_buffer_map (buf, &map, GST_MAP_READ);
>   gst_util_dump_mem(map.data, map.size);
>   gst_buffer_unmap (buf, &map);
>   g_print ("tags 1: %s\n", gst_tag_list_to_string (taglist));
>   g_print ("tags 2: %s\n", gst_tag_list_to_string (taglist2));
>   fail_unless (gst_tag_list_is_equal (taglist, taglist2));
>   gst_tag_list_unref (taglist2);
> }

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.