[Bug 725828] hlsdemux: reporting playlist and fragment download time stat

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725828
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271113|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-08 08:19:30 UTC ---
Review of attachment 271113:
 --> (https://bugzilla.gnome.org/review?bug=725828&attachment=271113)

Please use your real name in the patch, not just your last name :)

Some nitpicking, also not sure about the names really.

::: ext/hls/gsthlsdemux.c
@@ +118,3 @@
 G_DEFINE_TYPE (GstHLSDemux, gst_hls_demux, GST_TYPE_ELEMENT);

+#define GST_HLS_DEMUX_STATISTIC_MSG_NAME "hlsdemux-statistics"

MESSAGE_NAME

@@ +418,3 @@

+static void
+gst_hls_demux_post_stat_msg (GstHLSDemux * demux, GstStructure * structure)

post_statistics_message

@@ +1102,3 @@

+  stat_msg = gst_structure_new (GST_HLS_DEMUX_STATISTIC_MSG_NAME,
+      "time-to-playlist", GST_TYPE_CLOCK_TIME,

time-to-download-playlist maybe

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.