[Bug 726752] h264parser should also expose a framerate in the case of interlaced samples.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726752
  GStreamer | gst-plugins-bad | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tsaunier at gnome.org

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> 2014-04-08 15:37:06 UTC ---
(In reply to comment #2)
> Review of attachment 272447 [details]:
> 
> ::: gst-libs/gst/codecparsers/gsth264parser.c
> @@ -1346,3 @@
> 
> -    if (parse_vui_params && vui->fixed_frame_rate_flag &&
> -        sps->frame_mbs_only_flag && !vui->pic_struct_present_flag) {
> 
> Can you explain the reasoning a bit more? Why remove these two checks here,
> what do these flags mean and why can't they be ignored?

Basically the frame_mbs_only_flag determine whether the stream is interlaced or
not and pic_struct_present_flag will tell whether timestamps can be computed
for each frame, but in all cases the framerate is contained in the stream and
can be used. At least this is how I understand it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.