[Bug 727886] GstVideoGLTextureUploadMeta assumes no color conversion is done during upload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727886
  GStreamer | gst-plugins-base | git

--- Comment #6 from Carlos Rafael Giani <dv at pseudoterminal.org> 2014-04-10 01:14:11 UTC ---
(In reply to comment #5)
> Then negotiation will fail based on caps features.  Either both sides of the
> tee will support the meta or will not.

Which means that for every such meta, all of these elements (deinterlacer etc.)
have to be rewritten. Either that, or some kind of converter element, which
only complicates things and is actually unnecessary. Such a meta should never
rule out other features.

> > Changing the format in the caps just because a meta is added just feels wrong
> > to me. The caps should describe what is really inside. Additional mechanisms
> > like this meta are placed on top of that. They do not replace anything.
> 
> Also, there is no guarantee that mapping the buffer is supported when the meta
> exists, I would even suggest that mapping a buffer with the meta would be
> undefined behaviour.  The meta provides a way to get the data from a buffer to
> some GL texture/s of a specified format without downstream explicitly mapping
> the buffer.

There is a guarantee - if the SystemMemory caps feature is present, then it can
be mapped. Also, if a GstMemory inside the GstBuffer cannot be mapped (= has
the GST_MEMORY_FLAG_NOT_MAPPABLE flag set), then mapping will not be possible.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.