[Bug 727403] mpegts: add linkage, data_broadcast_id, private_data_specifier and parental_rating descriptors

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Apr 10 00:12:08 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=727403
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273858|none                        |needs-work
             status|                            |

--- Comment #25 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-10 07:12:05 UTC ---
Review of attachment 273858:
 --> (https://bugzilla.gnome.org/review?bug=727403&attachment=273858)

::: gst-libs/gst/mpegts/gst-dvb-descriptor.c
@@ +470,3 @@
+      GstMpegTsDVBLinkageMobileHandOver *hand_over;
+
+      g_return_val_if_fail (end - data < 1, FALSE);

Don't use g_return_val_if_fail() here. The g_return*_if_fail() assertions are
meant to catch programming errors, not invalid/corrupted data... and can be
compiled out like normal assertions too.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list