[Bug 721869] dvbsrc needs to conditionally build for older dvb headers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721869
  GStreamer | gst-plugins-bad | git

--- Comment #10 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2014-04-11 12:17:32 UTC ---
With your patch, configure doesn't select dvb to build, because I have version
5.4. If I build in sys/dvb anyway, I get the errors below.
As Stefan mentioned above, SYS_DVBC_ANNEX_AC is defined, fixed by the attached
patch (though it's not clear whether it's any good, as it changes the API), but
it's not clear what to do for _DELSYS, see after this log. _DELSYS isn't
defined in 5.4, but apparently becomes available at 5.5.


  CC     libgstdvb_la-gstdvbsrc.lo
gstdvbsrc.c: In function 'gst_dvbsrc_delsys_get_type':
gstdvbsrc.c:361:6: error: 'SYS_DVBC_ANNEX_A' undeclared (first use in this
function)
gstdvbsrc.c:361:6: note: each undeclared identifier is reported only once for
each function it appears in
gstdvbsrc.c:380:6: error: 'SYS_DVBC_ANNEX_C' undeclared (first use in this
function)
gstdvbsrc.c: In function 'gst_dvbsrc_open_frontend':
gstdvbsrc.c:1044:21: error: 'DTV_ENUM_DELSYS' undeclared (first use in this
function)
gstdvbsrc.c:1044:19: error: assignment makes integer from pointer without a
cast [-Werror]
gstdvbsrc.c:1074:46: error: 'SYS_DVBC_ANNEX_A' undeclared (first use in this
function)
gstdvbsrc.c:1074:3: error: passing argument 2 of 'gst_dvbsrc_check_delsys'
makes integer from pointer without a cast [-Werror]
gstdvbsrc.c:984:1: note: expected 'guchar' but argument is of type 'struct
GEnumValue *'
gstdvbsrc.c:1139:46: error: 'SYS_DVBC_ANNEX_C' undeclared (first use in this
function)
gstdvbsrc.c:1139:3: error: passing argument 2 of 'gst_dvbsrc_check_delsys'
makes integer from pointer without a cast [-Werror]
gstdvbsrc.c:984:1: note: expected 'guchar' but argument is of type 'struct
GEnumValue *'
gstdvbsrc.c: In function 'gst_dvbsrc_tune':
gstdvbsrc.c:1617:21: error: 'DTV_ENUM_DELSYS' undeclared (first use in this
function)
gstdvbsrc.c:1617:19: error: assignment makes integer from pointer without a
cast [-Werror]
gstdvbsrc.c:1709:12: error: 'SYS_DVBC_ANNEX_A' undeclared (first use in this
function)
gstdvbsrc.c:1711:12: error: 'SYS_DVBC_ANNEX_C' undeclared (first use in this
function)
cc1: all warnings being treated as errors
make: *** [libgstdvb_la-gstdvbsrc.lo] Error 1


With the patch I'm attaching in 10 seconds:

  CC     libgstdvb_la-gstdvbsrc.lo
gstdvbsrc.c: In function 'gst_dvbsrc_open_frontend':
gstdvbsrc.c:1050:21: error: 'DTV_ENUM_DELSYS' undeclared (first use in this
function)
gstdvbsrc.c:1050:21: note: each undeclared identifier is reported only once for
each function it appears in
gstdvbsrc.c: In function 'gst_dvbsrc_tune':
gstdvbsrc.c:1631:21: error: 'DTV_ENUM_DELSYS' undeclared (first use in this
function)
make: *** [libgstdvb_la-gstdvbsrc.lo] Error 1

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.