[Bug 721869] dvbsrc needs to conditionally build for older dvb headers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721869
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274086|none                        |needs-work
             status|                            |

--- Comment #12 from Edward Hervey <bilboed at bilboed.com> 2014-04-11 12:31:38 UTC ---
Review of attachment 274086:
 --> (https://bugzilla.gnome.org/review?bug=721869&attachment=274086)

::: sys/dvb/gstdvbsrc.c
@@ +362,3 @@
     {SYS_DVBC_ANNEX_A, "DVB-C-A", "dvb-c-a"},
+#else
+    {SYS_DVBC_ANNEX_AC, "DVB-C-AC", "dvb-c-ac"},

I think it would be cleaner if we just defined SYS_DVBC_ANNEX_A (same value as
the legacy SYS_DVBC_ANNEX_AC) instead of having one or the other.

It might just end up being way too confusing

This applies to all other usages of A/AC

@@ +385,2 @@
     {SYS_DVBC_ANNEX_C, "DVB-C-C", "dvb-c-c"},
+#endif

the DVB-C addition/protection this way is fine though.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.