[Bug 727945] funnel: element doesn't forward eos stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727945
  GStreamer | gstreamer (core) | 1.2.4

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274125|none                        |needs-work
             status|                            |

--- Comment #3 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-04-11 18:37:35 UTC ---
Review of attachment 274125:
 --> (https://bugzilla.gnome.org/review?bug=727945&attachment=274125)

::: plugins/elements/gstfunnel.c
@@ +159,3 @@
+
+  if (element->numsinkpads == 0) {
+    GST_OBJECT_UNLOCK (funnel);

Probably makes sense to put all of the unlocks in one place with a goto.

@@ +168,3 @@

+    /* eos event has not enrolled for current pad, we don't check for current
pad */
+    if ((pad != NULL) && (pad == sinkpad))

No need to check if the pas is NULL, if it's NULL, pad won't be equal to
sinkpad.

@@ +265,2 @@
       forward = FALSE;
+    } else if (funnel->last_sinkpad && (pad != funnel->last_sinkpad)) {

Same thing here, pad will never be NULL, so no need to check that last_sinkpad
is not NULL.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.