[Bug 727886] GstVideoGLTextureUploadMeta assumes no color conversion is done during upload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727886
  GStreamer | gst-plugins-base | git

--- Comment #19 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-04-14 17:56:42 UTC ---
(In reply to comment #18)
> http://cgit.collabora.com/git/user/gkiagia/gst-plugins-base.git/log/?h=gluploadmeta

I'd prefer simply ->format rather then uploaded_format. Also, for backward
compatiblity, you need to handle the case this is set to
GST_VIDEO_FORMAT_UNKNOWN (zero) in your implementation and need to be
documented.

> http://cgit.collabora.com/git/user/gkiagia/cogl.git/log/?h=gluploadmeta

Saying you have texture support for GST_VIDEO_FORMATS_ALL is most likely not
true. It should instead list the item you have in your switch, which I suppose
match BASE_SINK_CAPS.

Implementation of GstVideoGLTextureUploadMetaParams looks wrong to me and isn't
documented anywhere.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.