[Bug 728353] New: goom2k1: code does nothing, slowly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728353
  GStreamer | gst-plugins-good | git

           Summary: goom2k1: code does nothing, slowly
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: vincent.penquerch at collabora.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In gst/goom2k1/filters.c, zoomFilterSetResolution:

    for (loopv = zf->res_y; loopv != 0;) {
      int decc = 0;
      int spdc = 0;
      int accel = 0;

      loopv--;
      zf->firedec[loopv] = decc;
      decc += spdc / 10;               <---- adds 0
      spdc += RAND (gd) % 3;           <--\
      spdc -= RAND (gd) % 3;           <--/  those two make spdc range -2..2

      if (decc > 4)                    <----- this thus can't happen
        spdc -= 1;

And there's more below that.

I suspect spdc might have been intended to be outside the loop (ie, not be
reset to 0 every loop), but that's just a guess.

The code was added all in one go, so no history to shed some light upon this.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.