[Bug 728045] omxvideodec: support cropping information

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728045
  GStreamer | gst-omx | git

--- Comment #1 from Aurélien Zanelli <aurelien.zanelli at parrot.com> 2014-04-16 17:28:54 UTC ---
Created an attachment (id=274494)
 View: https://bugzilla.gnome.org/attachment.cgi?id=274494
 Review: https://bugzilla.gnome.org/review?bug=728045&attachment=274494

omxvideodec: implement decoder cropping information support

This is a preliminary work. It just query the output crop config at reconfigure
time and attach GstVideoCropMeta to buffer if downstream element support
videometa.

I don't like two things in this 'patch':
- I add a dependency to gstomxvideodec in gstomxbufferpool because I add
cropping info to GstOMXVideoDec structure.
- I attach GstVideoCropMeta to buffer if downstream element support video meta.

For the first point, I may add the cropping info in GstOMXBufferPool and move
cropping structure declaration to gstomx.c (it will just define a rect).
For the second point, we currently know that downstream element support crop
meta API when we parse the allocation query. However we don't have a specific
buffer pool option like for GST_VIDEO_META_API_TYPE. To solve this, we can
define a new option in gstvideopool.h (gst-plugins-base) or add a boolean to
GstOMXVideoDec to tell we want crop info and set associated flag in
GstOMVBufferPool in gst_omx_video_dec_allocate_output_buffers().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.