[Bug 728490] v4l2src: Missing unref in decide_allocation

Fri Apr 18 07:38:41 PDT 2014

https://bugzilla.gnome.org/show_bug.cgi?id=728490
  GStreamer | gst-plugins-good | 1.2.3

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274659|none                        |needs-work
             status|                            |

--- Comment #1 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-04-18 14:38:35 UTC ---
Review of attachment 274659:
 --> (https://bugzilla.gnome.org/review?bug=728490&attachment=274659)

::: sys/v4l2/gstv4l2src.c
@@ +529,1 @@
       pool = GST_BUFFER_POOL_CAST (obj->pool);

but does this mean you should ref obj->pool? otherwise aren't you giving the
ownership to the query ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.