[Bug 728502] ximagesrc has a serious shmem leak

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728502
  GStreamer | gst-plugins-good | 1.2.4

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274679|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-04-18 19:51:26 UTC ---
Review of attachment 274679:
 --> (https://bugzilla.gnome.org/review?bug=728502&attachment=274679)

Would it be possible to provide a patch formatted using git --format-patch -1 ?
This will also imply passing the code through the style checker.

::: sys/ximage/gstximagesrc.c
@@ +457,3 @@
   g_mutex_lock (&ximagesrc->pool_lock);
   while (ximagesrc->buffer_pool != NULL) {
+    if (ximage != NULL) // pool not empty yet, free previous ximage

Style: don't use C++ style comment, we try to avoid right comment too.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.