[Bug 727886] GstVideoGLTextureUploadMeta assumes no color conversion is done during upload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727886
  GStreamer | gst-plugins-base | git

--- Comment #32 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2014-04-22 15:23:39 UTC ---
(In reply to comment #31)
> (In reply to comment #30)
> > After my argument in comment #29, and considering the above, I want to make a
> > new proposal:
> > 
> > * Add indeed a new GstVideoGLTextureUploadMeta2 which will be defined as:
> 
> I think we agreed that if we where to create a new meta, we would give it a
> better name. An example could be GstVideoGLTextureMapMeta.

Ah true, I remember something. Agreed.

> > 
> > struct _GstVideoGLTextureUploadMeta2 {
> >   GstMeta       meta;
> > 
> >   GstVideoGLTextureOrientation texture_orientation;
> >   GstVideoInfo texture_info;
> 
> Any rational for the texture_ prefix ?

It was there before and I think it feels more descriptive, as the fields
represent information about the texture.

> > * The number of textures *must* be equal to the number of planes of the video
> > format set in texture_info.
> 
> Why ? Won't that prevent few platforms from using it ?

As far as I have seen, the number of textures equals the number of planes of
the given format. At least eglglessink used to assert this and glimagesink only
supports RGBA (and asserts that n_textures == 1), so I have no example of
another use case. Do you know one?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.