[Bug 728886] New: GstGLColorConvert: some unused params in shaders

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728886
  GStreamer | gst-plugins-bad | git

           Summary: GstGLColorConvert: some unused params in shaders
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: julien.isorce at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


1: For example tex_scale1 / tex_scale2 are declared but not used in
frag_REORDER :
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcolorconvert.c#n132

2: Also "i = info->in_n_textures"
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcolorconvert.c#n1049
looks suspicious as for example in videotestsrc ! RGB ! glimagesink it's equal
to 1. So we should only handle the case where i is 0 in this case.

3: Third thing is the "width" param which is not defined for most of the
shaders but we still try to set it:
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcolorconvert.c#n1061

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.