[Bug 727754] Enhancements to porting guide documentation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727754
  GStreamer | documentation | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273716|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-04-25 22:25:14 UTC ---
(From update of attachment 273716)
> docs/random/porting-to-1.0.txt |    9 +++++++++
> 1 file changed, 9 insertions(+)

Please provide a patch in 'git format-patch' format, so that we can just apply
it with 'git am' and it already contains author info and a commit message.

>diff --git a/docs/random/porting-to-1.0.txt b/docs/random/porting-to-1.0.txt
>index 341d9f9..3e83119 100644
>--- a/docs/random/porting-to-1.0.txt
>+++ b/docs/random/porting-to-1.0.txt
>@@ -716,6 +716,9 @@ CHANGES
>         garbled). Since 1.0.7 the "iradio-mode" property has been re-added
>         to allow users to switch off the default behaviour of requesting
>         icecast metadata.
>+      - fakesink's "silent" property default value changed from FALSE to TRUE.
>+        This means that "gst-launch-1.0 -v" will not show messages from
>+        fakesink unless you explicitly request them with "fakesink silent=0".

 - same is also true for the identity element (and, less importantly, also
fakesrc).

 - the explicit request should be via silent=false, it's a boolean not an
integer (although =0 will work too).

 - should also mention why it was changed (for efficiency reasons)


>@@ -739,6 +742,12 @@ CHANGES
> 
>           playbin uri=file:///path/to/foo.flac audio-sink=pulsesink
> 
>+ * non-time-based sources do not provide timestamps anymore
>+
>+      - Sources based on BYTEs instead of TIME (like filesrc or souphttpsrc)
>+        do not provide PTS anymore. In the 0.10 API they provided a PTS with
>+        value 0 for the first buffer. This was needed for legacy operation but
>+        has been removed in the 1.0 API.

This is not wrong, but also a bit misleading. Sources that output stuff in BYTE
format will usually still put a DTS=0 on the first buffer even if PTS is unset.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.