[Bug 727109] buffer: Should not set TAG_MEMORY if memory has not been replaced

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Apr 26 12:10:19 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=727109
  GStreamer | gstreamer (core) | git

--- Comment #7 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-04-26 19:10:12 UTC ---
Went for something much closer to the original idea, only set TAG_MEMORY if
memory has been replaced, and do a light check in release to discard buffer
which size has not bee set back to default. More complex pool should check each
memory individually.

commit ec69ad4e8adddc83d4cdc8c5608099d74f7397d3
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Wed Mar 26 15:56:08 2014 -0400

    buffer: Only set TAG_MEMORY if the memory has been replaced

    Currently we set TAG_MEMORY as soon a resize changes the size of one
    of the memory. This has the side effect that buffer pool cannot know if
    the memory have simply been resized, or if the memorys has been replaced.
    This make it hard to actually implement _reset(). Instead, only set the
    TAG_MEMORY if one or more memory has been replaced, and do a light
    sanity check of the size.

    https://bugzilla.gnome.org/show_bug.cgi?id=727109

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list