[Bug 728515] obsd-build: gst-autogen.sh export AUTOMAKE_VERSION which class with env used in automake wrapper

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Apr 27 09:45:52 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=728515
  GStreamer | common | 1.2.4

--- Comment #8 from Antoine Jacoutot <ajacoutot at gnome.org> 2014-04-27 16:45:47 UTC ---
(In reply to comment #7)
> Now, with this patch, the _VERSION will not be visible outside that function,
> is that right ? Why not simply removing that eval line, is it used somewhere ?

Yes it's right, it isn't used outside of this function. But it is used within
the function itself to check the full version (X.Y.Z).

> This fixes one clash, but we have no control over what will be used next in the
> OpenBSD automake wrapper. What if they start using AUTOMAKE_MINOR ? I wonder if
> there is a better solution here.

I don't see us using AUTOMAKE_MINOR for anything really :-)
But that said, even if it wasn't for OpenBSD, I still think the patch is
correct since this variable really should not get out of the function; it is
only used there.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list