[Bug 729067] goom filter: left shift of 24 places cannot be represented in type 'int'

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Apr 27 15:08:19 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=729067
  GStreamer | gst-plugins-good | git

--- Comment #4 from Luis de Bethencourt <luis at debethencourt.com> 2014-04-27 22:08:14 UTC ---
Created an attachment (id=275282)
 View: https://bugzilla.gnome.org/attachment.cgi?id=275282
 Review: https://bugzilla.gnome.org/review?bug=729067&attachment=275282

change precalCoef[][] to uint.

The result of the first patch was put into an int array, so it was merely
protecting for sign flipping due to an overflow.

This patch changes the array to allocate unsigned integers. The change is a bit
more intrusive, but would behave better with an overflow.

Let me know which one you prefer better.

Thanks for the review! :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list