[Bug 726814] Fix leak of AVBufferRef in gstavvidenc.c

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726814
  GStreamer | gst-libav | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272559|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-29 06:38:47 UTC ---
Review of attachment 272559:
 --> (https://bugzilla.gnome.org/review?bug=726814&attachment=272559)

Looks good in general but

::: ext/libav/gstavvidenc.c
@@ +596,3 @@

+  if (ret < 0 || !have_data)
+    g_slice_free (AVPacket, pkt);

Shouldn't this call gst_ffmpegvidenc_free_avpacket() too, i.e. also
av_packet_unref()?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.