[Bug 728451] glimagesink: expects a NSWindow instead of a NSView as the window handle

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728451
  GStreamer | gst-plugins-bad | git

--- Comment #4 from Julien Isorce <julien.isorce at gmail.com> 2014-04-29 07:50:21 UTC ---
So in order to move gst-plugins-gl/tests/examples/cocoa/videooverlay/main.m  to
-bad I did the following:

1- In in a clone dir of gst-plugins-gl:
git format-patch --subject-prefix="" --numbered  --root -- 
tests/examples/cocoa/

It generates 18 patches to keep this history:
http://cgit.freedesktop.org/gstreamer/gst-plugins-gl/log/tests/examples/cocoa

0001-add-Cocoa-xoverlay-interface-example.patch
0002-make-cocoa-backend-work-on-MacOSX.patch
0003-Cocoa-backend-fix-crash-when-resizing.patch
0004-Cocoa-backend-improve-support-on-GNUStep.patch
0005-tests-replace-_set_xwindow_id-with-_set_window_handl.patch
0006-cocoa-example-remove-white-spaces.patch
0007-cocoa-example-do-not-set-pipeline-to-null-state-twic.patch
0008-objc-add-GST_OBJCFLAGS-and-friends.patch
0009-Update-versioning-for-gstreamer-1.0.patch
0010-tests-update-for-1.0.patch
0011-update-add-.gitignore-files.patch
0012-determine-the-GL-platform-to-use-at-runtime.patch
0013-fix-cocoa-videooverlay-example.patch
0014-remove-GNUstep-makefiles.patch
0015-fix-build-failure-when-building-Cocoa-tests.patch
0016-Use-gst_object_-un-ref-so-we-can-get-refcounts-in-th.patch
0017-cocoa-fix-build-when-GNUSTEP-is-not-defined.patch
0018-gl-Some-less-long-ulong-gulong-usage.patch

For example the content of 0001-add-Cocoa-xoverlay-interface-example.patch is :
...
From: Julien Isorce <julien.isorce at gmail.com>
Date: Sat, 7 Mar 2009 03:17:04 +0100
Subject: [01/18] add Cocoa xoverlay interface example
...

2- In a clone dir of gst-plugins-bad, from master branch:
git checkout -b move_gl_cocoa_example
git am -3 -k *.patch  (-k to keep [n/m])

3- now merge:
git checkout master
git merge --no-ff -m "examples: move cocoa-videooverlay from gst-plugins-gl"
move_gl_cocoa_example

the log would looks like:

commit a170e4ede596ff81a03ce70c83ced91bc3d49617
Merge: 4e90366 a0154c
Author: Julien Isorce <julien.isorce at gmail.com>
Date:   Sun Apr 27 19:36:20 2014 +0100

    examples: move cocoa-videooverlay from gst-plugins-gl

commit a0154cbbed3303769042514f37cc75de59bf48df
Author: Sebastian Dröge <slomo at circular-chaos.org>
Date:   Wed Jul 17 11:22:02 2013 +0200

    [18/18] gl: Some less long/ulong/gulong usage

commit f33a1d381b5c8b1e9220e94b97f27bc349948614
Author: Julien Isorce <julien.isorce at gmail.com>
Date:   Wed Jul 10 15:47:23 2013 +0100

    [17/18] cocoa: fix build when GNUSTEP is not defined

commit 99df7c26cd471122234fbc7ce055780b76e4c96f
Author: Matthew Waters <ystreet00 at gmail.com>
Date:   Thu Jun 13 14:36:41 2013 +1000

...

    [01/18] ...


But then I would like to rename the test from tests/examples/cocoa to
tests/examples/overlay/cocoa-videooverlay.m to match same naming as in
gst-plugins-base.

The result is that git log tests/examples/overlay will no show the old history.
It would require to do git log --follow

It would be the same result as gstglimagesink.c :
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/log/ext/gl/gstglimagesink.c
where we do not see commits earlier than the move except if you pass --follow

It is ok to do this way ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.