[Bug 729245] New: gl: rename platform cocoa to cgl to be more consistent with context type

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729245
  GStreamer | gst-plugins-bad | git

           Summary: gl: rename platform cocoa to cgl to be more consistent
                    with context type
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: julien.isorce at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


1- we should rename GST_GL_HAVE_PLATFORM_COCOA to GST_GL_HAVE_PLATFORM_CGL:
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcontext.c#n214

to uniform with name used with gst_gl_context_get_gl_platform which return
GST_GL_PLATFORM_CGL
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/cocoa/gstglcontext_cocoa.m#n348

Those enum are defined here:
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglapi.h#n117


That would also make more sense to do GST_GL_PLATFORM=cgl GST_GL_WINDOW=cocoa
instead of GST_GL_PLATFORM=cocoa GST_GL_WINDOW=cocoa videotestsrc ! glimagesink

Also on the cocoa doc you can read: "Every NSOpenGLContext object wraps a
low-level, platform-specific Core OpenGL (CGL) context. Your application can
retrieve the CGL context by calling the CGLContextObj method.", cf:
https://developer.apple.com/library/mac/documentation/cocoa/reference/applicationkit/classes/NSOpenGLContext_Class/Reference/Reference.html

2 -missing context type CGL (and EAGL):
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcontext.h#n50

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.