[Bug 729268] New: libav: avoid using wrong number of samples
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Apr 30 07:36:18 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=729268
GStreamer | gst-libav | git
Summary: libav: avoid using wrong number of samples
Classification: Platform
Product: GStreamer
Version: git
OS/Version: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gst-libav
AssignedTo: gstreamer-bugs at lists.freedesktop.org
ReportedBy: vincent.penquerch at collabora.co.uk
QAContact: gstreamer-bugs at lists.freedesktop.org
GNOME version: ---
Created an attachment (id=275492)
View: https://bugzilla.gnome.org/attachment.cgi?id=275492
Review: https://bugzilla.gnome.org/review?bug=729268&attachment=275492
avoid using wrong number of samples
If audio_in is NULL, we'll send a NULL frame to libav, to flush
the codec. In that case, we won't know how many samples the codec
will have used, so we use -1 (for don't know) when letting the
base class know about the buffer.
I'm not 100% sure this is correct, as the base class will then try to calculate
a number of samples if passed a negative value. However, a comment says it is
a best guess only. So up for comments just in case.
See also https://bugzilla.gnome.org/show_bug.cgi?id=724536
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list