[Bug 729760] appsrc: Changing caps and pushing buffers is not serialized

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Aug 5 19:08:50 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=729760
  GStreamer | gst-plugins-base | git

comicfans44 <comicfans44> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282124|0                           |1
        is obsolete|                            |

--- Comment #20 from comicfans44 <comicfans44 at gmail.com> 2014-08-06 02:08:44 UTC ---
Created an attachment (id=282618)
 View: https://bugzilla.gnome.org/attachment.cgi?id=282618
 Review: https://bugzilla.gnome.org/review?bug=729760&attachment=282618

v4 based on Sebastian Dröge (slomo) 's comment

(In reply to comment #19)
> Good point. I think you would want to just put them always into the queue, but
> check if they are equal to the current caps right before setting them. That
> will keep the code a bit simpler while having the same effect.
improved in new patch.

>Here I was more thinking about a symmetric loop instead of this
I didn't change to this, since there is continue/goto/nullable ,makes common
gst_mini_object_unref difficult

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list