[Bug 734344] aiffparse: pointers not unreferred

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734344
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282646|none                        |rejected
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-06 10:04:27 UTC ---
Review of attachment 282646:
 --> (https://bugzilla.gnome.org/review?bug=734344&attachment=282646)

How can these memory leaks be made visible? Running the unit test in valgrind
with "make elements/aiffparse.valgrind" does not show any leaks.

::: tests/check/elements/aiffparse.c
@@ +123,2 @@
       have_tags = TRUE;
+      g_free (tags);

This is a static array that does not need to be freed

@@ +123,3 @@
       have_tags = TRUE;
+      g_free (tags);
+      gst_tag_list_free (aiff_tags);

the tags returned by gst_event_parse_tags() is not owned by the caller (see the
transfer none annotation). It's only valid as long as the event is valid, and
the caller is not supposed to free them

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.