[Bug 733556] h264 payloader : append packetization-mode parameter for SDP

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733556
  GStreamer | gst-plugins-good | 1.4.0

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282550|none                        |needs-work
             status|                            |

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-08-06 11:27:44 UTC ---
(From update of attachment 282550)
>+#define DEFAULT_PACKETIZATION_MODE      1

This define does not really match our conventions. The other DEFAULT_FOO
defines are for GObject properties, but what you're adding here is not a
property.

>+    packet_mode = g_strdup_printf ("%d", DEFAULT_PACKETIZATION_MODE);
> ...
>       res = gst_rtp_base_payload_set_outcaps (basepayload,
>+          "packetization-mode", G_TYPE_STRING, packet_mode,
>           "profile-level-id", G_TYPE_STRING, profile,
>           "sprop-parameter-sets", G_TYPE_STRING, sprops->str, NULL);

If it's effectively a constant, you might just as well code it as such in the
code, i.e.

>+          "packetization-mode", G_TYPE_STRING, "1",

That's shorter and more readable. I haven't checked yet if we conform to all
the constraints implied by this mode yet though.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.