[Bug 733916] Simple pipeline with textoverlay and fakesink fails to negotiate

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Aug 8 09:48:29 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=733916
  GStreamer | gst-plugins-base | 1.4.0

--- Comment #10 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-08-08 16:48:26 UTC ---
Created an attachment (id=282934)
 View: https://bugzilla.gnome.org/attachment.cgi?id=282934
 Review: https://bugzilla.gnome.org/review?bug=733916&attachment=282934

basetextoverlay: rework caps negotiation

Make textoverlay negotiate caps more correctly.

1) Check what caps we received in the video-sink
2) If it already has the overlay meta -> use it directly
3) If it doesn't, textoverlay try adding the overlay meta and using it,
   if downstream doesn't support it, just use what is received in the
   video-sink
4) Check if the allocation query also supports the meta to enable
   really using it

Before it wasn't really doing renegotiation of any kind, just
re-checking if it should use the overlay meta or not

Also had to update the caps in the test as memory:SystemMemory seems
to be required when you use a caps feature otherwise intersection/subset
checks will fail.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list