[Bug 734517] opusenc: Unref pad template caps after usage

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Aug 10 03:43:58 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=734517
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282975|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-08-10 10:43:54 UTC ---
(From update of attachment 282975)
>-  caps =
>-      gst_caps_copy (gst_pad_get_pad_template_caps (GST_AUDIO_ENCODER_SINK_PAD
>-          (benc)));
>+  caps = gst_pad_get_pad_template_caps (GST_AUDIO_ENCODER_SINK_PAD (benc));
>   if (!allow_multistream) {
>     GValue range = { 0 };
>     g_value_init (&range, GST_TYPE_INT_RANGE);

This is not correct. The code goes on to modify the returned caps in some
cases, so they need to be writable.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list