[Bug 734521] sbcenc: Unref output caps in error cases

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734521
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282979|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-08-10 10:53:49 UTC ---
(From update of attachment 282979)
>-  else
>+  else {
>+    gst_caps_unref (output_caps);
>     return FALSE;
>+  }

>-  else
>+  else {
>+    gst_caps_unref (output_caps);
>     return FALSE;
>+  }

>-  else
>+  else {
>+    gst_caps_unref (output_caps);
>     return FALSE;
>+  }
> 
>-  else
>+  else {
>+    gst_caps_unref (output_caps);
>     return FALSE;
>+  }
> 
>-  if (!gst_audio_encoder_set_output_format (audio_enc, output_caps))
>+  if (!gst_audio_encoder_set_output_format (audio_enc, output_caps)) {
>+    gst_caps_unref (output_caps);
>     return FALSE;
>+  }

Please add an 'error' or 'failure' or whatever goto label that does the unref +
return FALSE and just 'goto' there instead.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.