[Bug 734412] multiqueue: The buffering logic can lead to a pipeline stuck in PAUSED forever

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734412
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282767|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-11 07:55:21 UTC ---
Review of attachment 282767:
 --> (https://bugzilla.gnome.org/review?bug=734412&attachment=282767)

Or maybe if one of the queues is full and we would post a buffering message, we
should instead allow for the full queue to grow until buffering is done?

Otherwise your patch looks good, just not sure if that's the correct solution
as it basically disables buffering completely for such pipelines.

::: plugins/elements/gstmultiqueue.c
@@ +828,3 @@
     gst_single_queue_flush_queue (sq, full);
+
+    GST_MULTI_QUEUE_MUTEX_LOCK (mq);

Why do you move the lock?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.