[Bug 734482] Make OpenGL plugins more accessible for application programmers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734482
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282912|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-11 08:16:00 UTC ---
Review of attachment 282912:
 --> (https://bugzilla.gnome.org/review?bug=734482&attachment=282912)

::: ext/gl/gstgltransformation.c
@@ +308,3 @@
       break;
+    case PROP_MVP:
+      filter->mvp_matrix = *((graphene_matrix_t *) g_value_get_boxed (value));

Storing boxed types by pointer is a bit weird... but ok :) Nonetheless you need
to check for NULL here, which should probably be handled like the identity
matrix

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.