[Bug 733351] queue2: Process SEEKING query

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733351
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281085|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-11 08:49:01 UTC ---
Review of attachment 281085:
 --> (https://bugzilla.gnome.org/review?bug=733351&attachment=281085)

::: plugins/elements/gstqueue2.c
@@ +3043,3 @@
+        if (segment_end < 0) {
+          GST_DEBUG_OBJECT (queue, "fixing seekable segment to maximum");
+          segment_end = G_MAXINT64;

IIRC -1 for the seeking query also has the meaning that the complete range can
be seeked.


However I'm not sure it's valid to assume that upstream is seekable if the
seeking query failed upstream. The queue will be seekable in the already
downloaded area, but otherwise no seeking is possible.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.