[Bug 734412] multiqueue: The buffering logic can lead to a pipeline stuck in PAUSED forever

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734412
  GStreamer | gstreamer (core) | unspecified

--- Comment #10 from Thibault Saunier <tsaunier at gnome.org> 2014-08-11 12:01:03 UTC ---
(In reply to comment #8)
> Review of attachment 283076 [details]:
> 
> ::: plugins/elements/gstmultiqueue.c
> @@ +924,3 @@
>        mq->buffering = TRUE;
>        mq->percent = percent;
>        post = TRUE;
> 
> Does this make sense? You set multiqueue to buffering mode...
> 
> @@ +933,3 @@
> +        post = FALSE;
> +
> +        break;
> 
> ... but don't post a buffering message. Wouldn't it be clearer to just store
> the maximum percentage all the time, and also only have mq->buffering==TRUE if
> we actually posted a message that would trigger buffering?
> 
> It seems like this here only makes the code even harder to understand, even if
> it probably does the right thing :)

That last patch fixes the mistake pointed out here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.