[Bug 733087] Add WebP Image encoder
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Aug 11 05:49:15 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=733087
GStreamer | gst-plugins-bad | unspecified
--- Comment #8 from sreerenj <bsreerenj at gmail.com> 2014-08-11 12:49:11 UTC ---
(In reply to comment #2)
> Review of attachment 280545 [details]:
>
> Looks good, just some minor comments and questions
> @@ +398,3 @@
> +
> + enc->webp_config.lossless = enc->lossless;
> + enc->webp_config.method = enc->speed;
>
> Why do you call it speed, while the webp API calls it method?
WebpConfig.method is "quality/speed trade-off (0=fast, 6=slower-better)" . The
word speed is more appropriate for user. The word "method" doesn't make much
sense from users perspective IMHO.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list