[Bug 733916] Simple pipeline with textoverlay and fakesink fails to negotiate

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733916
  GStreamer | gst-plugins-base | 1.4.0

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.4.1
         OS/Version|Linux                       |All

--- Comment #12 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-08-11 16:22:56 UTC ---
master:

commit a080c0ebbf989930dde3b3575317057bb13dd4da
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Fri Aug 8 12:46:47 2014 -0300

    basetextoverlay: rework caps negotiation

    Make textoverlay negotiate caps more correctly.

    1) Check what caps we received in the video-sink
    2) If it already has the overlay meta -> use it directly
    3) If it doesn't, textoverlay try adding the overlay meta and using it,
       if downstream doesn't support it, just use what is received in the
       video-sink
    4) Check if the allocation query also supports the meta to enable
       really using it

    Before it wasn't really doing renegotiation of any kind, just
    re-checking if it should use the overlay meta or not

    Also had to update the caps in the test as memory:SystemMemory seems
    to be required when you use a caps feature otherwise intersection/subset
    checks will fail.

    https://bugzilla.gnome.org/show_bug.cgi?id=733916

commit c20e044ef0021f0046cc6941dbc8618dc4d37e0b
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Thu Aug 7 17:35:05 2014 -0300

    basetextoverlay: always intersect with the filter caps

    Avoids returning values that upstream can't produce

    https://bugzilla.gnome.org/show_bug.cgi?id=733916

commit 33c2372ae3b0dbc70bfe8abe3e1a95cd1881ba22
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Mon Aug 11 12:22:44 2014 -0300

    assrender: improve negotiation

    Check if downstream supports overlay meta, if possible use it and
    if not fallback to no-overlay caps

    https://bugzilla.gnome.org/show_bug.cgi?id=733916

commit 7895d8836945706c037e2308a75a3728b3d988db
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Mon Aug 11 12:21:28 2014 -0300

    assrender: always intersect with the filter caps

    Avoids returning values that peers can't use

    https://bugzilla.gnome.org/show_bug.cgi?id=733916

commit eee178988ad2d7ad03163bb59cdf9b4cc79a517d
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Mon Aug 11 11:35:01 2014 -0300

    dvbsuboverlay: improve negotiation

    Check if downstream supports overlay meta, if possible use it and
    if not fallback to no-overlay caps

    https://bugzilla.gnome.org/show_bug.cgi?id=733916

commit 627b6ac4617b370bb71012cced10c71672265eba
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Mon Aug 11 11:33:28 2014 -0300

    dvbsuboverlay: always intersect with the filter in getcaps

    Avoids returning unsupported caps to peers

    https://bugzilla.gnome.org/show_bug.cgi?id=733916


1.4:
base
commit d79cd056e7490d1fd4a8a232b905896b3104fee0
commit 93643695be6e83af204a6ba29e58b6566a92f18d
bad
commit f64b974c4d4a9f6732c9f63d6575f615f4e80cd5
commit 9f9493598c561cc6e736e3800557c82ceac405c3
commit 28fc15f236374f4423e2565cf0a85cf8aa3fed04
commit e0a878aef3fa381f181f9ff17ce2b31667ac0635

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.