[Bug 734648] Error not handled properly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734648
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283166|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-12 10:23:12 UTC ---
Review of attachment 283166:
 --> (https://bugzilla.gnome.org/review?bug=734648&attachment=283166)

::: tests/check/pipelines/oggmux.c
@@ +265,3 @@
       error ? error->message : "(invalid error)");
+  if (error != NULL)
+    g_error_free (error);

You can just use g_clear_error(&error) here without the if, however this should
be no problem. If there is an error it will fail the test anyway before even
reaching these lines

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.