[Bug 734716] bus: signal watched added in a new thread-default context can't be removed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734716
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283280|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-13 12:36:31 UTC ---
Review of attachment 283280:
 --> (https://bugzilla.gnome.org/review?bug=734716&attachment=283280)

::: gst/gstbus.c
@@ +1317,3 @@
 gst_bus_remove_signal_watch (GstBus * bus)
 {
+  GSource *source = 0;

Use NULL instead of 0

@@ +1333,3 @@

+  GST_DEBUG_OBJECT (bus, "removing signal watch %u",
+      bus->priv->signal_watch_id);

%p

@@ +1337,2 @@
+  bus->priv->signal_watch_id = 0;
+  source = bus->priv->watch_id;

And change the priv->watch_id guint to a GSource * and make sure to actually
store the GSource there instead of the return value of attach(). And also unref
the source after you're done with it, not just destroy it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.