[Bug 735078] New: gst_gl_handle_set_context may unref a NULL GstGLDisplay

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735078
  GStreamer | gst-plugins-bad | git

           Summary: gst_gl_handle_set_context may unref a NULL
                    GstGLDisplay
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: comicfans44 at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I found  last commit changed gstglutils.c:770

   gst_object_replace ((GstObject **) display, (GstObject *) replacement);

to

  if (replacement) {
    GstGLDisplay *old = *display;
    *display = replacement;
    gst_object_unref (old);  --> didn't consider NULL
  }

should this check if old!=NULL first, or should this be

if (replacement) {
 gst_object_replace ((GstObject **) display, (GstObject *) replacement);
 gst_object_unref(replacement);
}

?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.