[Bug 734482] Make OpenGL plugins more accessible for application programmers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734482
  GStreamer | gst-plugins-bad | unspecified

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283997|none                        |needs-work
             status|                            |

--- Comment #14 from Matthew Waters <ystreet00 at gmail.com> 2014-08-21 07:52:40 UTC ---
Review of attachment 283997:
 --> (https://bugzilla.gnome.org/review?bug=734482&attachment=283997)

One issue :).

::: ext/gl/gstgltransformation.c
@@ +309,3 @@
+    case PROP_MVP:
+      if (value != NULL)
+        filter->mvp_matrix = *((graphene_matrix_t *) g_value_get_boxed
(value));

You need to check if the value returned by g_value_get_boxed is not NULL (not
value != NULL)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.