[Bug 735032] Refactoring of GstZebraStripe element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735032
  GStreamer | gst-plugins-bad | unspecified

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283859|none                        |reviewed
             status|                            |

--- Comment #1 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-08-25 17:50:36 UTC ---
Review of attachment 283859:
 --> (https://bugzilla.gnome.org/review?bug=735032&attachment=283859)

Nice catch, some comments for more readability below.

::: gst/videofilters/gstzebrastripe.c
@@ +221,3 @@
     case GST_VIDEO_FORMAT_Y444:
     case GST_VIDEO_FORMAT_Y42B:
+      data_a = 1;

GST_VIDEO_FORMAT_INFO_PSTRIDE can be used to get those values for data_a

@@ +241,3 @@
+        (guint8 *) frame->data[0] + frame->info.stride[0] * j + offset;
+    for (i = 0; i < width; i++) {
+      if (data[data_a * i + data_b] >= threshold) {

How about using more significative names for data_a and data_b.

data_a seems to be the pixel stride and data_b the index of the Y inside the
pixel. Maybe something like pixel_stride and y_position or similar.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.