[Bug 732533] gstomx omxvideoenc don't recover after aspect ratio change on RPI

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732533
  GStreamer | gst-omx | 1.2.4

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284574|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-27 07:09:36 UTC ---
Review of attachment 284574:
 --> (https://bugzilla.gnome.org/review?bug=732533&attachment=284574)

See how this is done in gstomxvideodec.c. Look for
GST_OMX_HACK_NO_COMPONENT_RECONFIGURE

It should be done optionally via that hack flag, and ideally with the same code
as there.

::: omx/gstomxvideoenc.c
@@ +1100,3 @@
       return FALSE;
+    if (gst_omx_component_set_state (self->enc, OMX_StateIdle) !=
OMX_ErrorNone)
+      return FALSE;

Why do you only go to Idle here and not Loaded too?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.