[Bug 735378] gstrtpjitterbuffer: requests retransmission periodically when no needed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735378
  GStreamer | gst-plugins-good | 1.3.3

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284521|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-27 07:23:38 UTC ---
Review of attachment 284521:
 --> (https://bugzilla.gnome.org/review?bug=735378&attachment=284521)

::: gst/rtpmanager/gstrtpjitterbuffer.c
@@ +130,3 @@
 #define DEFAULT_DO_RETRANSMISSION   FALSE
 #define DEFAULT_RTX_DELAY           -1
+#define DEFAULT_RTX_MIN_DELAY       0

Shouldn't this have a non-zero default? If I understand your problem correctly
the code currently sends rtx requests immediately if the packet did not arrive
at the expected time. And the expected time does not have any tolerance for
jitter or anything in the network or producer.

@@ +545,3 @@
+   * GstRtpJitterBuffer:rtx-min-delay:
+   *
+   * When a packet did not arrive at the expected time, wait al least this
extra amount

typo: al -> at

@@ +548,3 @@
+   * of time before sending a retransmission event.
+   *
+   * Since: 1.3

Since: 1.6

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.