[Bug 729811] Output-selector test example in gstreamer plugin base is giving "Internal data flow error".

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729811
  GStreamer | gst-plugins-base | 1.0.10

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284576|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-27 07:30:05 UTC ---
Review of attachment 284576:
 --> (https://bugzilla.gnome.org/review?bug=729811&attachment=284576)

Makes sense to me but I guess it should do this for all sticky events then? Or
even all events?

::: plugins/elements/gstoutputselector.c
@@ +542,3 @@
+      active = gst_output_selector_get_active (sel);
+      if (active) {
+        res = gst_pad_set_caps (active, caps);

Why not just forward the caps event directly with gst_pad_push_event(active,
event)?

@@ +547,3 @@
+        res = FALSE;
+      }
+      gst_caps_unref (caps);

I think you need to unref the event here too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.