[Bug 735569] Crash due to no protection of waths readsrc.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735569
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284662|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-28 07:54:32 UTC ---
Review of attachment 284662:
 --> (https://bugzilla.gnome.org/review?bug=735569&attachment=284662)

The same seems to be true for the writesrc.

::: gst-libs/gst/rtsp/gstrtspconnection.c
@@ +2935,3 @@
   guint id;
   GMutex mutex;
+  GMutex readsrc_mutex;

Why not just reuse the existing mutex?

@@ +3413,2 @@
   if (watch->conn->input_stream) {
+    g_mutex_lock (&watch->readsrc_mutex);

Just put the lock/unlock outside the if/else block

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.