[Bug 735581] imagefreeze: Refactoring element
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Aug 28 03:23:05 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=735581
GStreamer | gst-plugins-good | unspecified
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #284669|none |needs-work
status| |
--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-28 10:22:59 UTC ---
Review of attachment 284669:
--> (https://bugzilla.gnome.org/review?bug=735581&attachment=284669)
Please write the commit messages in the style the others are:
elementname: Short description
long description
over multiple
lines
https://bugzilla.gnome.org/1234567
::: gst/imagefreeze/gstimagefreeze.c
@@ +670,3 @@
GstImageFreeze *self = GST_IMAGE_FREEZE (parent);
+ g_return_val_if_fail ((self->buffer == NULL), GST_FLOW_ERROR);
The () around the condition are not needed
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list