[Bug 727483] v4l2sink: Keep aspect ratio when device scale

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727483
  GStreamer | gst-plugins-good | unspecified

Aurélien Zanelli <aurelien.zanelli> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282139|none                        |needs-work
             status|                            |

--- Comment #6 from Aurélien Zanelli <aurelien.zanelli at parrot.com> 2014-08-28 15:57:51 UTC ---
Review of attachment 282139:
 --> (https://bugzilla.gnome.org/review?bug=727483&attachment=282139)

This patch is not complete because if device supports overlay, I think the crop
window should be tested against the overlay window rather than the format.

::: sys/v4l2/v4l2_calls.c
@@ +1178,3 @@
   v4l2object->vcropcap = cropcap;
   v4l2object->can_crop = TRUE;
+

format.type is not set

@@ +1200,3 @@
+    if (format.fmt.pix_mp.width != crop.c.width ||
+        format.fmt.pix_mp.height != crop.c.height)
+      v4l2object->can_scale = FALSE;

Mistake, should be v4l2object->can_scale = TRUE

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.