[Bug 725145] libde265 based HEVC/H.265 decoder plugin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725145
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284725|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-29 09:09:55 UTC ---
Review of attachment 284725:
 --> (https://bugzilla.gnome.org/review?bug=725145&attachment=284725)

::: ext/libde265/libde265-dec.c
@@ +755,3 @@
+  }
+  gst_video_frame_unmap (&outframe);
+  frame->pts = (GstClockTime) de265_get_image_PTS (img);

Instead of this, get the corresponding GstVideoCodecFrame and don't overwrite
the pts in the frame

@@ +769,3 @@
+  de265_error ret = DE265_OK;
+  int more = 0;
+  de265_PTS pts = (de265_PTS) frame->pts;

Note that pts can be GST_CLOCK_TIME_NONE (i.e. -1) but frame->dts could contain
useful values. You're supposed to generate PTS from the DTS in that case.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.