[Bug 735509] oggdemux: should accumulate segment.base

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735509
  GStreamer | gst-plugins-base | unspecified

--- Comment #4 from Guillaume Desmottes <gdesmott at gnome.org> 2014-08-29 12:27:32 UTC ---
Yeah I agree segment.base should be 0, len, 2 * len, etc.

if I do:
      segment.base = gst_segment_to_running_time (&ogg->segment,
          GST_FORMAT_TIME, ogg->segment.position);

I end up with:
 0 (position = 0 and ogg->segment.base = 0)
 2 * len (position = len and ogg->segment.base = len)
so the second sample is delayed.

But if I do:
      segment.base = gst_segment_to_running_time (&ogg->segment,
          GST_FORMAT_TIME, start);

I have:
 0 (start = 0 and ogg->segment.base = 0)
 len (start = 0 and ogg->segment.base = len)
 2 * len (start = 0 and ogg->segment.base = 2 * len)
as expected.

Actually, an even easier fix would be just to *not* change segment.base at all
and just keep ogg->segment.base. Would that be ok?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.