[Bug 735660] v4l2: fix new v4l2 code not working with certain devices (regression)

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Aug 29 06:08:55 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=735660
  GStreamer | gst-plugins-good | 1.4.1

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284800|reviewed                    |rejected
             status|                            |

--- Comment #6 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-08-29 13:08:53 UTC ---
Review of attachment 284800:
 --> (https://bugzilla.gnome.org/review?bug=735660&attachment=284800)

::: sys/v4l2/gstv4l2allocator.c
@@ +489,3 @@
+    breq.count = 0;
+    breq.memory = memory;
+    v4l2_ioctl (allocator->video_fd, VIDIOC_REQBUFS, &breq);

Just spoke with Hans. 18 drivers are affected, 16 in 3.17. Though he said:à

<hverkuil> Realistically, if reqbufs(0) is not supported by the driver, then
the only safe alternative is to close and reopen the device node.

So this patch isn't correct.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list