[Bug 735660] v4l2: fix new v4l2 code not working with certain devices (regression)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735660
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #20 from Hans de Goede <jwrdegoede at fedoraproject.org> 2014-08-30 10:26:16 UTC ---
Created an attachment (id=284882)
 View: https://bugzilla.gnome.org/attachment.cgi?id=284882
 Review: https://bugzilla.gnome.org/review?bug=735660&attachment=284882

[PATCH] v4l2allocator: Workaround driver that don't support REQBUFS(0)

(In reply to comment #16)
> Actually there is a subtle difference in what I had in mind, I would probe
> REQBUFS(0) for all case first (as we do now), then if the flags are 0 (no
> capabilities), I'd warn and set the MMAP capability.

Right, that is exactly what I had in mind too, but I could have worded it
better. Thanks for the patch, I've slightly modified it making 2 changes:

1) Move the GST_OBJECT_FLAG_SET call to after fixing up the flags
2) Add the last chunk from my original patch, which makes reqbufs(0) failing in
gst_v4l2_allocator_stop non fatal

With these 2 fixes the patch works fine (tested on a bttv card), I'm attaching
the updated version now.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.